Fix StackOverflowError for LLA with non-Number arguments#112
Open
asinghvi17 wants to merge 1 commit intomainfrom
Open
Fix StackOverflowError for LLA with non-Number arguments#112asinghvi17 wants to merge 1 commit intomainfrom
asinghvi17 wants to merge 1 commit intomainfrom
Conversation
Add type constraints to the LLA outer constructor to match the existing LatLon pattern, preventing infinite recursion when called with non-Number types like `missing`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLA(missing, missing)caused aStackOverflowErrordue to infinite recursion in the outer constructor::Numbertype constraints to theLLAouter constructor, matching the existing pattern used byLatLon(from LatLon(missing, missing) triggers a stack overflow error #47)LLA(missing, missing)now throwsMethodErrorTest plan
LLA(missing, missing)throwsMethodErrorinstead ofStackOverflowError🤖 Generated with Claude Code